fix: remove node-fetch dependency, use custom fetch implementation #8486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
reviewed
Aug 26, 2021
dgozman
approved these changes
Aug 26, 2021
| async function sendRequest(url: URL, options: http.RequestOptions & { maxRedirects: number }, postData?: Buffer): Promise<Response>{ | ||
| return new Promise<Response>((fulfill, reject) => { | ||
| const requestConstructor: ((url: URL, options: http.RequestOptions, callback?: (res: http.IncomingMessage) => void) => http.ClientRequest) | ||
| = (url.protocol === 'https:' ? https : http).request; |
There was a problem hiding this comment.
I believe we don't need them. Data url can be easily loaded directly in a page. We can always add it later if there is demand.
mxschmitt
reviewed
Aug 27, 2021
| return result; | ||
| } | ||
|
|
||
| const redirectStatus = [301, 302, 303, 307, 308]; |
There was a problem hiding this comment.
nit: please move that before sendRequest, otherwise code navigation is weird.
| status === 303 && !['GET', 'HEAD'].includes(method)) { | ||
| redirectOptions.method = 'GET'; | ||
| postData = undefined; | ||
| delete redirectOptions.headers?.[`content-encoding`]; |
There was a problem hiding this comment.
redirectionOptions.headers is coming from the options. Do you ensure there that the user is passing the headers in lower-case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compared to node-fetch current implementation doesn't support decompression of the results yet. Also cookie handling on redirects will be added later.
#5999