Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fetch): make fetch api public #8853

Merged
merged 4 commits into from Sep 11, 2021
Merged

feat(fetch): make fetch api public #8853

merged 4 commits into from Sep 11, 2021

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Sep 10, 2021

@yury-s yury-s requested a review from dgozman September 10, 2021 22:40
dgozman
dgozman approved these changes Sep 10, 2021
View reviewed changes
docs/src/api/class-fetchresponse.md

Returns the JSON representation of response body.

This method will throw if the response body is not parsable via `JSON.parse`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "JSON.parse" a thing in dotnet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno, I copied it from our current Response docs. @avodovnik ^^

docs/src/api/class-route.md Show resolved Hide resolved
types/types.d.ts Show resolved Hide resolved
@yury-s yury-s merged commit b618005 into microsoft:master Sep 11, 2021
@yury-s yury-s deleted the fetch-public branch September 11, 2021 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yury-s @dgozman