Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): add types for tests #915

Merged
merged 2 commits into from Feb 10, 2020

Conversation

JoelEinbinder
Copy link
Contributor

I enabled vscode autocomplete in our test files. Typechecking had too many errors to enable, but it caught some real bugs that I will fix in a follow up.

This patch contains:

  • test/types.d.ts - d.ts file for our test runner.
  • test/tsconfig.json - typescript project for our tests.
  • JSDoc header in all specs to mark the describe as a TestSuite
  • Drive-by fix of a launcher test that was using if instead of it
  • Some drive-by fixes of unimpactful typos in tests.

@dgozman
Copy link
Contributor

dgozman commented Feb 10, 2020

  • test/types.d.ts - d.ts file for our test runner.
  • test/tsconfig.json - typescript project for our tests.

Nice one, but these two files are missing. Could you please re-upload?

@JoelEinbinder
Copy link
Contributor Author

  • test/types.d.ts - d.ts file for our test runner.
  • test/tsconfig.json - typescript project for our tests.

Nice one, but these two files are missing. Could you please re-upload?

Oops. Fixed.

Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

@JoelEinbinder JoelEinbinder merged commit c03e8b7 into microsoft:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants