feat(coverage): expose raw v8 coverage #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
coverage
branch
from
25defc5
to
27999cf
Compare
lukeapage
reviewed
Feb 13, 2020
| @@ -82,7 +99,7 @@ class JSCoverage { | |||
| this._resetOnNavigation = resetOnNavigation; | |||
| this._reportAnonymousScripts = reportAnonymousScripts; | |||
| this._enabled = true; | |||
| this._scriptURLs.clear(); | |||
| this._scriptIds.clear(); | |||
| this._scriptSources.clear(); | |||
| this._eventListeners = [ | |||
| helper.addEventListener(this._client, 'Debugger.scriptParsed', this._onScriptParsed.bind(this)), | |||
There was a problem hiding this comment.
Thanks for this! I've tested a simple hack with raw coverage and it works nicely, apart from:
5 lines down from this we have:
this._client.send('Profiler.startPreciseCoverage', {callCount: false, detailed: true}),
I can get a really nice coverage report with istanbul if we get callCount info:
this._client.send('Profiler.startPreciseCoverage', {callCount: true, detailed: true}),
There was a problem hiding this comment.
Sounds good, counting calls now.
pavelfeldman
force-pushed
the
coverage
branch
2 times, most recently
from
df2ba5a
to
658a16f
Compare
aslushnikov
reviewed
Feb 13, 2020
src/chromium/crCoverage.ts
Outdated
| if (!ranges) { | ||
| ranges = []; | ||
| styleSheetIdToCoverage.set(entry.styleSheetId, ranges); | ||
| const entries = new Map<string, CSSCoverageEntry>(); |
There was a problem hiding this comment.
These changes are scary: I'm not sure CSS coverage actually yields disjoint ranges (and IIRC we had some problems here).
Can we keep the old codepath for CSS coverage?
pavelfeldman
force-pushed
the
coverage
branch
from
658a16f
to
3cd776e
Compare
aslushnikov
reviewed
Feb 14, 2020
| @@ -11,6 +11,6 @@ | |||
| "end": 433 | |||
| } | |||
| ], | |||
| "text": "\n@charset \"utf-8\";\n@namespace svg url(http://www.w3.org/2000/svg);\n@font-face {\n font-family: \"Example Font\";\n src: url(\"./Dosis-Regular.ttf\");\n}\n\n#fluffy {\n border: 1px solid black;\n z-index: 1;\n /* -webkit-disabled-property: rgb(1, 2, 3) */\n -lol-cats: \"dogs\" /* non-existing property */\n}\n\n@media (min-width: 1px) {\n span {\n -webkit-border-radius: 10px;\n font-family: \"Example Font\";\n animation: 1s identifier;\n }\n}\n" | |||
| "source": "\n@charset \"utf-8\";\n@namespace svg url(http://www.w3.org/2000/svg);\n@font-face {\n font-family: \"Example Font\";\n src: url(\"./Dosis-Regular.ttf\");\n}\n\n#fluffy {\n border: 1px solid black;\n z-index: 1;\n /* -webkit-disabled-property: rgb(1, 2, 3) */\n -lol-cats: \"dogs\" /* non-existing property */\n}\n\n@media (min-width: 1px) {\n span {\n -webkit-border-radius: 10px;\n font-family: \"Example Font\";\n animation: 1s identifier;\n }\n}\n" | |||
pavelfeldman
force-pushed
the
coverage
branch
from
b7c5073
to
1fbef01
Compare
pavelfeldman
force-pushed
the
coverage
branch
from
1fbef01
to
754455b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #955