Merge pull request #274 from microsoft/disable-warnings-as-errors

Disable warnings as errors
microsoft · Jan 24, 2023 · a494faa · a494faa
2 parents b1a342d + 20cc0f0
commit a494faa
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.azure-pipelines/azure-pipelines.yml b/.azure-pipelines/azure-pipelines.yml
@@ -30,7 +30,7 @@ jobs:
       scheme: 'CrashReporter'
       xcodeVersion: specifyPath
       xcodeDeveloperDir: '$(XCODE_PATH)'
-      args: 'SYMROOT="$(Build.BinariesDirectory)"'
+      args: 'SYMROOT="$(Build.BinariesDirectory)" GCC_TREAT_WARNINGS_AS_ERRORS=YES SWIFT_TREAT_WARNINGS_AS_ERRORS=YES'
 
   - bash: |
       cp -f "Release-macosx/libCrashReporter.a" "Release/Static/libCrashReporter-MacOSX-Static.a"

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # PLCrashReporter Change Log
 
+## Version 1.11.1 (Under development)
+
+* **[Improvement]** Disable treating warnings as errors in code to avoid blockers when new Xcode warnings are introduced.
+
 ## Version 1.11.0
 
 * **[Feature]** Add Xcode 14 support. Xcode 11 and Xcode 12 are out of support now.

diff --git a/CrashReporter.xcodeproj/project.pbxproj b/CrashReporter.xcodeproj/project.pbxproj
@@ -4092,7 +4092,7 @@
 					PLCR_PRIVATE,
 					PLCF_DEBUG_BUILD,
 				);
-				GCC_TREAT_WARNINGS_AS_ERRORS = YES;
+				GCC_TREAT_WARNINGS_AS_ERRORS = NO;
 				GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
 				GCC_WARN_ABOUT_RETURN_TYPE = YES;
 				GCC_WARN_UNDECLARED_SELECTOR = YES;
@@ -4157,7 +4157,7 @@
 					PLCR_PRIVATE,
 					PLCF_RELEASE_BUILD,
 				);
-				GCC_TREAT_WARNINGS_AS_ERRORS = YES;
+				GCC_TREAT_WARNINGS_AS_ERRORS = NO;
 				GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
 				GCC_WARN_ABOUT_RETURN_TYPE = YES;
 				GCC_WARN_UNDECLARED_SELECTOR = YES;