Fix a build error if the source folder has a space #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the source folder has a space in the path then the build fails as $(dirname "$0")/combine-libraries.sh has a space in it. This changes adds quotes around the directory name.
DmitriyKirakosyan
approved these changes
Jul 26, 2021
|
Thank you for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the source folder has a space in the path then the build for iOS fails as $(dirname "$0")/combine-libraries.sh has a space in it. This changes adds quotes around the directory name.
Things to consider before you submit the PR:
CHANGELOG.mdbeen updated?Description
Allow the project to build if the source folder has a space in the path
Related PRs or issues
List related PRs and other issues.
Misc
Did a visual review of other scripts in the Scripts folder and they seem to be ok.