Adding -All parameter for retrieving all the workspaces. (Works only with Organization scope) #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandemoii
suggested changes
Dec 26, 2018
src/Modules/Workspaces/Commands.Workspaces/help/Get-PowerBIWorkspace.md
Outdated
Show resolved
Hide resolved
src/Modules/Workspaces/Commands.Workspaces/GetPowerBIWorkspace.cs
Outdated
Show resolved
Hide resolved
src/Modules/Workspaces/Commands.Workspaces/GetPowerBIWorkspace.cs
Outdated
Show resolved
Hide resolved
src/Modules/Workspaces/Commands.Workspaces/GetPowerBIWorkspace.cs
Outdated
Show resolved
Hide resolved
src/Modules/Workspaces/Commands.Workspaces.Test/WorkspacesTestUtilities.cs
Outdated
Show resolved
Hide resolved
src/Modules/Workspaces/Commands.Workspaces.Test/WorkspacesTestUtilities.cs
Outdated
Show resolved
Hide resolved
src/Modules/Workspaces/Commands.Workspaces.Test/WorkspacesTestUtilities.cs
Outdated
Show resolved
Hide resolved
src/Modules/Workspaces/Commands.Workspaces.Test/GetPowerBIWorkspaceTests.cs
Show resolved
Hide resolved
src/Modules/Workspaces/Commands.Workspaces.Test/GetPowerBIWorkspaceTests.cs
Show resolved
Hide resolved
shpittam
commented
Dec 27, 2018
nandemoii
reviewed
Dec 28, 2018
src/Modules/Workspaces/Commands.Workspaces.Test/GetPowerBIWorkspaceTests.cs
Outdated
Show resolved
Hide resolved
nandemoii
reviewed
Dec 28, 2018
src/Modules/Workspaces/Commands.Workspaces.Test/GetPowerBIWorkspaceTests.cs
Outdated
Show resolved
Hide resolved
CodeCyclone
requested changes
Jan 2, 2019
src/Modules/Workspaces/Commands.Workspaces.Test/GetPowerBIWorkspaceTests.cs
Outdated
Show resolved
Hide resolved
src/Modules/Workspaces/Commands.Workspaces.Test/GetPowerBIWorkspaceTests.cs
Show resolved
Hide resolved
src/Modules/Workspaces/Commands.Workspaces.Test/GetPowerBIWorkspaceTests.cs
Show resolved
Hide resolved
src/Modules/Workspaces/Commands.Workspaces.Test/GetPowerBIWorkspaceTests.cs
Outdated
Show resolved
Hide resolved
src/Modules/Workspaces/Commands.Workspaces.Test/GetPowerBIWorkspaceTests.cs
Show resolved
Hide resolved
src/Modules/Workspaces/Commands.Workspaces/GetPowerBIWorkspace.cs
Outdated
Show resolved
Hide resolved
src/Modules/Workspaces/Commands.Workspaces/GetPowerBIWorkspace.cs
Outdated
Show resolved
Hide resolved
src/Modules/Workspaces/Commands.Workspaces/GetPowerBIWorkspace.cs
Outdated
Show resolved
Hide resolved
src/Modules/Workspaces/Commands.Workspaces/help/Get-PowerBIWorkspace.md
Outdated
Show resolved
Hide resolved
nandemoii
reviewed
Jan 3, 2019
src/Modules/Workspaces/Commands.Workspaces/GetPowerBIWorkspace.cs
Outdated
Show resolved
Hide resolved
nandemoii
approved these changes
Jan 3, 2019
src/Modules/Workspaces/Commands.Workspaces/GetPowerBIWorkspace.cs
Outdated
Show resolved
Hide resolved
| @@ -71,6 +81,16 @@ protected override void BeginProcessing() | |||
| { | |||
| base.BeginProcessing(); | |||
|
|
|||
| if (this.First > 5000) | |||
There was a problem hiding this comment.
Consider thinking about how to include this check in the GetCmdlet class.
CodeCyclone
approved these changes
Jan 4, 2019
src/Modules/Workspaces/Commands.Workspaces/GetPowerBIWorkspace.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.