Linting fix #93
Merged
Linting fix #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zBritva
approved these changes
Jul 3, 2023
zBritva
approved these changes
Jul 13, 2023
|
bump the visual version, and looks good for me then |
Done: a82853c |
uve
requested changes
Aug 2, 2023
|
Looks good to merge |
uve
approved these changes
Aug 4, 2023
uve
pushed a commit
to uve/powerbi-visuals-sunburst
that referenced
this pull request
Aug 4, 2023
Co-authored-by: Alexander Metzger <alexander@metzger.dk> fixed unit tests fixed tests fixed lint fixed actions
uve
pushed a commit
to uve/powerbi-visuals-sunburst
that referenced
this pull request
Aug 4, 2023
Co-authored-by: Alexander Metzger <alexander@metzger.dk> fixed unit tests fixed tests fixed lint fixed actions
uve
added a commit
that referenced
this pull request
Aug 4, 2023
* Microsoft mandatory file (#90) Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> * Update build.yml * Update build.yml * squashed linting fix (#93) Co-authored-by: Alexander Metzger <alexander@metzger.dk> fixed unit tests fixed tests fixed lint fixed actions * fixed actions --------- Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Alexander Metzger <97496861+SanderGi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did I do?
Linting has been fixed by updating config in .stylelintrc following the CHANGELOG and migration guide. I also added es-lint following the power-bi standards. Finally, I fixed the code and styles to pass the linting
Why did I do it this way?
Because es-lint with this config is required for Microsoft certification. I kept stylelint since it was already part of the project and I just fixed it to actually work
Anything else you should know?
Everything passes locally but not on github due to chromeheadless not starting. I see this issue on other PRs as well, so I think the github enviroment needs to be updated
Screenshots
No visual changes:
