Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix branch-solution for Ubuntu runners. Fixes #229 #407

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Fix branch-solution for Ubuntu runners. Fixes #229 #407

merged 2 commits into from
Jul 18, 2023

Conversation

tehcrashxor
Copy link
Member

The GH security model won't let us access repo feed secrets used in the PR validation builds in PRs from forks.
repo-local branch created from sccle:main, originally submitted as PR #405
CC: @sccle

Fixes #229 (again): Running with an ubuntu-latest runner, the branch-solution action fails with the message: Error: failed: Error: Cannot determine HEAD from remote: ...

This PR reintroduces the fix, this time also in src.

In Windows, the current code is only working due to broken line-splitting of the command output (see #406).

@tehcrashxor tehcrashxor requested a review from a team July 18, 2023 16:17
@tehcrashxor tehcrashxor mentioned this pull request Jul 18, 2023
Closed
@tehcrashxor tehcrashxor merged commit 0c80aac into main Jul 18, 2023
5 checks passed
@tehcrashxor tehcrashxor deleted the sccle-main branch July 18, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochuk petrochuk petrochuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

branch-solution fails with Ubuntu runners
3 participants
@tehcrashxor @petrochuk @sccle