Gavenkat updateonlinesolutionversion #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehcrashxor
requested changes
Jul 25, 2023
There was a problem hiding this comment.
When this task was implemented in PPBT (ADO version), the task was named set-solution-version.
For consistency, we should also name this one set-solution-version, or perhaps keep the 'online' term to help distinguish between the two solution version related tasks.
Maybe set-solution-online-version?
@petrochuk , thoughts on the naming?
|
The other github action to update the solution version in the xml file was named as update-solution-version. Hence named this one update-online-solution-version. Can change this to keep it consistent with ADO one (but still retain the online keyword to differentiate set-online-solution-version).
|
auto-merge was automatically disabled
July 26, 2023 03:49
Pull request was converted to draft
…solution-version renamed the action from update-online-solution-version to set-online-solution-version to make it consistent with the ADO Build tasks
|
Renamed the action to be consistent with the ADO build tasks @tehcrashxor @petrochuk |
tehcrashxor
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added action for updating the solution version online