powerplatform-vscode Loc Checkin for WO 66644 #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tehcrashxor
requested changes
Jun 17, 2022
There was a problem hiding this comment.
After adding the translations-import/vscode-powerplatform.*.xlf files, you will also need to build the repo locally to generate the translated json files, and check those in.
See Contributing.md for general instructions on that, though the gist is
- create an
msazureorg PAT here with the Packaging -> Read scope - store that PAT in an environment variable
AZ_DevOps_Read_PAT - run
npm install - run
npm run ci - check in the generated
*.jsontranslation files
|
@tehcrashxor, I added the json files after fixing missing translations. Please review. Thanks a lot! |
tehcrashxor
requested changes
Jun 23, 2022
There was a problem hiding this comment.
@v-hifuku-msft , looks like checked in the i18n/**/*.i18n.json files generated by your local build, but did not check in the package.nls.*.json files that the build generates at the root of the repository. Please commit those as well.
tehcrashxor
approved these changes
Jun 23, 2022
v-hifuku-msft
deleted the
users/v-hifuku/powerplatform-vscode_main_06172022T0921
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Localization completed in Work Order 66644