initial changes for webExtension telemetry #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joem-msft
requested changes
Jun 29, 2022
|
|
||
| export function activate(context: vscode.ExtensionContext): void { | ||
| console.log("Activated web extension!"); // sample code for testing the webExtension | ||
| // setup telemetry | ||
| _telemetry = new TelemetryReporter(context.extension.id, context.extension.packageJSON.version, AI_KEY); |
There was a problem hiding this comment.
please use the AI key for development instance since this extension is not (hopefully) public yet.
…oints to align with the new folder structure
joem-msft
requested changes
Jul 4, 2022
joem-msft
approved these changes
Jul 5, 2022
| _telemetry = new TelemetryReporter(context.extension.id, context.extension.packageJSON.version, AI_KEY); | ||
| context.subscriptions.push(_telemetry); | ||
| _telemetry.sendTelemetryEvent("Start"); | ||
| _telemetry.sendTelemetryEvent("activated"); |
There was a problem hiding this comment.
this line should be the last line of the function. as it is in the other extensions.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting up telemetry for the Portal WebExtension.