Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication for Powerpages webextension #226

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

vedg
Copy link
Contributor

@vedg vedg commented Jul 6, 2022

@TylerLeonhardt
Copy link
Member

As an aside, can you tell me why this extension needs to be activated for:

  • onStartupFinished
  • onLanguage:yaml
  • onLanguage:html

From my perspective, this extension isn't going to be used all the time to warrant these events and an extension activating when it shouldn't need to ends up annoying customers and impacts performance.

@vedg vedg merged commit f72456c into main Jul 6, 2022
@vedg vedg deleted the users/vedgarbha/0607_authentication branch July 6, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants