Power Pages vscode.dev web extension schema and local store added #229

vedg · 2022-07-07T08:53:42Z

Power Pages vscode.dev web extension schema and local store added

Requirements added here: https://github.com/microsoft/vscode-dev/issues/477

Testing:

npm run compile-web
tested with portal route - http://localhost:3000/powerplatform/default/adx_webtemplates/97a5603a-3ab0-ec11-9840-000d3a5a4b78?orgUrl=orgca400f6b.crm.dynamics.com&source=dataverse&schema=portalDataverseoldschema

src/web/client/common/localStore.ts

ashishchoudhary001 · 2022-07-07T11:16:39Z

src/web/client/common/portalSchema.ts

@@ -0,0 +1,6264 @@
+export const portal_schema_data = {
+    "entities":{
+       "organization":[


let's rename this to rootEntity or commonEntity or fallbackEntity
organization is very specific to Dataverse. In case of GitHub it won't be relevant.

On second thought I feel dataSourceProperties would be even more relevant and aligned with our terminologies.

ashishchoudhary001 · 2022-07-07T11:19:21Z

src/web/client/common/portalSchema.ts

@@ -0,0 +1,6264 @@
+export const portal_schema_data = {
+    "entities":{
+       "organization":[


Why is this an array?

this is same as entities.fields , keepign the schema str intact

ashishchoudhary001 · 2022-07-07T11:21:20Z

src/web/client/common/constants.ts

+ * Licensed under the MIT License. See License.txt in the project root for license information.
+ * ------------------------------------------------------------------------------------------ */
+
+export const PORTAL_LANGUAGES = 'adx_portallanguages';


If we are going to have constants other than Dataverse constants then we should have an Enum to group the constants properly.

will take up in next iteration

ashishchoudhary001 · 2022-07-07T11:23:04Z

src/web/client/common/localStore.ts

+
+    try {
+        const requestUrl = getCustomRequestURL(dataverseOrg, PORTAL_LANGUAGES, PORTAL_LANGUAGES_URL_KEY);
+        const req = await fetch(requestUrl, {


I guess this is response, please rename.

ashishchoudhary001 · 2022-07-07T11:29:42Z

src/web/client/common/localStore.ts

+            const options = { detail: 'Auth failed in language id code', modal: true };
+            vscode.window.showErrorMessage("Language code fetch failed", options);
+        }
+        const res = await req.json();


If the response isn't a JSON this will throw an exception. But our catch block isn't handling that exception.

ashishchoudhary001 · 2022-07-07T11:32:24Z

src/web/client/common/localStore.ts

+    } catch (e: any) {
+        if (e.message === 'Unauthorized') {
+            const options = { detail: 'Auth failed in language id code', modal: true };
+            vscode.window.showErrorMessage("Language code fetch failed", options);


this implementation is being repeated across every API call. Please move it a common function.

ashishchoudhary001 · 2022-07-07T11:34:42Z

src/web/client/common/localStore.ts

+
+    try {
+        const requestUrl = getCustomRequestURL(dataverseOrg, WEBSITE_LANGUAGES, WEBSITE_LANGUAGES_URL_KEY);
+        const req = await fetch(requestUrl, {


same as above, this response not a request.

ashishchoudhary001 · 2022-07-07T11:34:57Z

src/web/client/common/localStore.ts

+        const req = await fetch(requestUrl, {
+            headers: getHeader(accessToken),
+        });
+        if (!req.ok) {


this implementation is being repeated across every API call. Please move it a common function.

ashishchoudhary001 · 2022-07-07T11:40:21Z

src/web/client/common/localStore.ts

+            }
+        }
+    } catch (e: any) {
+        if (e.message === 'Unauthorized') {


this is a very specific implementation and I don't think we should look for the exact string match for error handling.

Is this not caught above in the (!req.ok)?

Can this be based on errorCode instead of string comparison?

exception will not be caught in !req.ok, have enhanced this

ashishchoudhary001 · 2022-07-07T11:43:13Z

src/web/client/common/localStore.ts

+    return { webpagestowebpagesId };
+}
+
+export async function setLocalStore(accessToken: any, dataverseOrg: any) {


consider renaming this to setContext()

ashishchoudhary001 · 2022-07-07T11:45:51Z

src/web/client/common/portalSchemaReader.ts

+
+import { portal_schema_data } from "./portalSchema";
+
+export function readSchema() {


why do we need this function? The only thing it is doing is invoking another function.

ashishchoudhary001 · 2022-07-07T11:47:27Z

src/web/client/common/portalSchemaReader.ts

+    return organizationMap
+}
+
+export function getOrganizationMap() {


Depending on the name of the Organizations object in the Schema, please rename these.

ashishchoudhary001 · 2022-07-08T05:03:24Z

src/web/client/extension.ts

                            break;
-
+setContext


is this wrongly put here?

ashishchoudhary001 · 2022-07-08T07:40:42Z

src/web/client/common/localStore.ts

+        }
+        else {
+            showErrorDialog("Error processing the adx_languages response", "Language code response failure");
+            throw e;


Is this deliberate? I don't see the calling function handling this exception.

will remove this in fetch PR

Ved Garbha added 2 commits July 7, 2022 14:16

local store for website language details and schema file added

cc3e8e5

renamed var and redundant logs removed

34ede7a

vedg requested a review from ashishchoudhary001 July 7, 2022 08:54

vedg commented Jul 7, 2022

View reviewed changes

src/web/client/common/localStore.ts Outdated Show resolved Hide resolved

ashishchoudhary001 reviewed Jul 7, 2022

View reviewed changes

refactoring and organization to datasourceproperties change

e669df7

vedg requested a review from ashishchoudhary001 July 8, 2022 04:48

ashishchoudhary001 reviewed Jul 8, 2022

View reviewed changes

src/web/client/extension.ts Outdated

break;

setContext

Copy link

Contributor

ashishchoudhary001 Jul 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this wrongly put here?

reactoring and schema change

7f55e8d

ashishchoudhary001 reviewed Jul 8, 2022

View reviewed changes

ashishchoudhary001 approved these changes Jul 8, 2022

View reviewed changes

vedg merged commit e416247 into main Jul 8, 2022

vedg deleted the users/vedgarbha/schema_0707 branch July 8, 2022 08:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Power Pages vscode.dev web extension schema and local store added #229

Power Pages vscode.dev web extension schema and local store added #229

vedg commented Jul 7, 2022

ashishchoudhary001 Jul 7, 2022

ashishchoudhary001 Jul 8, 2022

vedg Jul 8, 2022

ashishchoudhary001 Jul 7, 2022

vedg Jul 8, 2022

ashishchoudhary001 Jul 7, 2022

vedg Jul 8, 2022

ashishchoudhary001 Jul 7, 2022

vedg Jul 8, 2022

ashishchoudhary001 Jul 7, 2022

ashishchoudhary001 Jul 7, 2022

ashishchoudhary001 Jul 7, 2022

ashishchoudhary001 Jul 7, 2022

vedg Jul 8, 2022

ashishchoudhary001 Jul 7, 2022

vedg Jul 8, 2022

ashishchoudhary001 Jul 7, 2022

ashishchoudhary001 Jul 7, 2022

ashishchoudhary001 Jul 7, 2022

ashishchoudhary001 Jul 8, 2022

ashishchoudhary001 Jul 8, 2022

vedg Jul 8, 2022


		import { portal_schema_data } from "./portalSchema";

		export function readSchema() {

Power Pages vscode.dev web extension schema and local store added #229

Power Pages vscode.dev web extension schema and local store added #229

Conversation

vedg commented Jul 7, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment