Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to show walkthrough only for the first run experience #299

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

ashishchoudhary001
Copy link
Contributor

Contains changes to show walkthrough only for the first run experience

image

@@ -158,7 +158,7 @@ async function createContentFiles(
PowerPlatformExtensionContextManager.updateSingleFileUrisInContext(vscode.Uri.parse(fileUri));

// Display only the last file
vscode.window.showTextDocument(vscode.Uri.parse(fileUri));
vscode.commands.executeCommand('vscode.open', vscode.Uri.parse(fileUri), {background: true, preview: false});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will still prompt to open the default file in editor right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prompt?
But yes, it will open the default file in editor just as it used to do earlier (only difference is this time it will open it in non-preview[Permanent] mode).

@ashishchoudhary001 ashishchoudhary001 merged commit bf8ec80 into main Sep 29, 2022
@ashishchoudhary001 ashishchoudhary001 deleted the users/aschoud/launch_walkthrough branch September 29, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants