Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data model load file content fix (#693) #694

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

tyaginidhi
Copy link
Contributor

Original PR cherry picked here: #693

@tyaginidhi tyaginidhi marked this pull request as ready for review September 11, 2023 17:28
@tyaginidhi tyaginidhi requested a review from a team as a code owner September 11, 2023 17:28
Copy link
Contributor

@petrochuk petrochuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an incident associated with this change?

@tyaginidhi tyaginidhi enabled auto-merge (squash) September 11, 2023 17:45
@tyaginidhi
Copy link
Contributor Author

tyaginidhi commented Sep 11, 2023

Is there an incident associated with this change?

Not yet - but this was reported as P0 by our internal testing team. This will break key functionality on new data model webfiles. (New data model is our new backend scehma which all orgs will eventually migrate to. Sharing more details on impacted users in chat)

@tyaginidhi tyaginidhi dismissed petrochuk’s stale review September 11, 2023 18:51

updated with comment

@tyaginidhi tyaginidhi merged commit 7989c62 into release/stable Sep 11, 2023
6 checks passed
@tyaginidhi tyaginidhi deleted the users/nityagi/WebfileV2QFE branch September 11, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants