Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross folder dependency (folder reference restriction will be added in a new PR) #990

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tyaginidhi
Copy link
Contributor

This pull request primarily involves refactoring and reorganizing the codebase for better structure and maintainability. The most significant changes are related to the relocation of the ITelemetry interface and associated telemetry events, as well as adjustments to import paths due to file relocations.

Here are the top five most important changes:

  1. Refactoring of ITelemetry Interface and Telemetry Events:

    The ITelemetry interface and associated telemetry events have been moved from the src/client/telemetry/ directory to the src/common/OneDSLoggerTelemetry/telemetry/ directory. This change affects numerous files across the codebase, with updates to import statements to reflect the new location. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18]

  2. Relocation of OrgChangeNotifier.ts:

    The OrgChangeNotifier.ts file has been moved from the src/common/ directory to the src/client/ directory. The import paths within this file have been updated accordingly. [1] [2]

  3. Update of Constants:

    Several constants have been updated across different files. For instance, PAC_SUCCESS has been replaced with SUCCESS in src/client/OrgChangeNotifier.ts, and telemetryEventNames has been replaced with desktopTelemetryEventNames in src/client/extension.ts. [1] [2]

  4. Refactoring of Import Paths:

    Due to the relocation of various files, import paths have been updated in several files, such as src/client/extension.ts, src/client/lib/CliAcquisition.ts, src/client/lib/GeneratorAcquisition.ts, and many others. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20]

  5. Removal of Unused Imports:

    Unused imports have been removed from several files, such as src/client/extension.ts and src/client/lib/CliAcquisition.ts, contributing to cleaner, more efficient code. [1] [2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant