Static type inspection. #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanBoltonMN
commented
May 26, 2020
|
|
||
| export type TriedType = Result<Type.TType, CommonError.CommonError>; | ||
|
|
||
| export function tryScopeType( |
There was a problem hiding this comment.
Returns typing for each item in the given scope.
JordanBoltonMN
commented
May 26, 2020
| return ResultUtils.ensureResult(getLocalizationTemplates(settings.locale), () => inspectScopeType(state, nodeId)); | ||
| } | ||
|
|
||
| export function tryType( |
There was a problem hiding this comment.
Returns typing for a single node.
JordanBoltonMN
commented
May 26, 2020
| @@ -141,6 +112,103 @@ export function letKeyValuePairs( | |||
| return maybeArrayWrapper === undefined ? [] : keyValuePairs(nodeIdMapCollection, maybeArrayWrapper); | |||
| } | |||
|
|
|||
| export function fieldProjectionFieldSelectors( | |||
There was a problem hiding this comment.
Several new helper functions for iterating over TXorNodes.
JordanBoltonMN
commented
May 26, 2020
| @@ -735,7 +735,7 @@ export function readRecursivePrimaryExpression<S extends IParserState = IParserS | |||
| const recursiveArrayNodeKind: Ast.NodeKind.ArrayWrapper = Ast.NodeKind.ArrayWrapper; | |||
| IParserStateUtils.startContext(state, recursiveArrayNodeKind); | |||
|
|
|||
| const recursiveExpressions: Ast.TRecursivePrimaryExpression[] = []; | |||
| const recursiveExpressions: (Ast.InvokeExpression | Ast.ItemAccessExpression | Ast.TFieldAccessExpression)[] = []; | |||
There was a problem hiding this comment.
Stricter typing.
JordanBoltonMN
commented
May 26, 2020
| @@ -1368,7 +1370,7 @@ export function readFieldSpecificationList<S extends IParserState = IParserState | |||
| ); | |||
| const fields: Ast.ICsv<Ast.FieldSpecification>[] = []; | |||
| let continueReadingValues: boolean = true; | |||
| let maybeOpenRecordMarkerConstant: Ast.IConstant<Ast.MiscConstantKind.Ellipsis> | undefined = undefined; | |||
| let isOnOpenRecordMarker: boolean = false; | |||
There was a problem hiding this comment.
Bug fix where the open record constant marked as the child of the inccorrect node.
JordanBoltonMN
commented
May 26, 2020
| @@ -93,95 +107,3 @@ function functionParameterXorNodes( | |||
| ? [] | |||
| : NodeIdMapIterator.arrayWrapperCsvXorNodes(nodeIdMapCollection, maybeWrappedContent); | |||
| } | |||
|
|
|||
| function examineParameter( | |||
There was a problem hiding this comment.
moved to TypeUtils
mattmasson
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the existing POC for static type inspection.