Skip to content

Commit

Permalink
Remove sys sxit when show pfs status (#3417)
Browse files Browse the repository at this point in the history
# Description

Please add an informative description that covers that changes made by
the pull request and link all relevant issues.

# All Promptflow Contribution checklist:
- [ ] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [ ] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [ ] Pull request includes test coverage for the included changes.

Co-authored-by: Ying Chen <2601502859@qq.com>
  • Loading branch information
YingChen1996 and Ying Chen committed Jun 19, 2024
1 parent 2f6eccf commit 6d14c4a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion src/promptflow-devkit/promptflow/_cli/_pf/_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -342,4 +342,3 @@ def show_service():
f"Prompt flow service is not started. The prompt flow service log is located at {log_file.as_posix()} "
f"and prompt flow version is {get_pfs_version()}."
)
sys.exit(1)
Original file line number Diff line number Diff line change
Expand Up @@ -70,5 +70,4 @@ def test_start_service(self, capsys):
finally:
port = get_port_from_config()
kill_exist_service(port=port)
with pytest.raises(SystemExit):
self._run_pfs_command("status")
self._run_pfs_command("status")

0 comments on commit 6d14c4a

Please sign in to comment.