Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Executor] Support node_concurrency when running an async flow #1698

Merged
merged 6 commits into from
Jan 19, 2024
Merged

[Executor] Support node_concurrency when running an async flow #1698

merged 6 commits into from
Jan 19, 2024

Conversation

Jasmin3q
Copy link
Contributor

@Jasmin3q Jasmin3q commented Jan 10, 2024 •
edited
Loading

Description

Use asyncio.semaphore to support concurrency control.

When node_concurrency is set to 2:
sync_passthrough1 and async_passthrough1 can run concurrently:
1705287434459

When node_concurrency is set to 1:
Only one of sync_passthrough1 and async_passthrough1 can at the same time:
1705288060087

@Jasmin3q Jasmin3q requested a review from a team as a code owner January 10, 2024 06:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2024 •
edited
Loading

SDK CLI Global Config Test Result shimin/add_node_concurrency

2 tests   2 ✅  47s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit e95d6f9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2024 •
edited
Loading

promptflow SDK CLI Azure E2E Test Result shimin/add_node_concurrency

  4 files    4 suites   2m 47s ⏱️
120 tests 101 ✅ 19 💤 0 ❌
480 runs  404 ✅ 76 💤 0 ❌

Results for commit e95d6f9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2024 •
edited
Loading

Executor Unit Test Result shimin/add_node_concurrency

695 tests   692 ✅  36s ⏱️
  1 suites    3 💤
  1 files      0 ❌

Results for commit e95d6f9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2024 •
edited
Loading

Executor E2E Test Result shimin/add_node_concurrency

171 tests   168 ✅  4m 48s ⏱️
  1 suites    3 💤
  1 files      0 ❌

Results for commit e95d6f9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2024 •
edited
Loading

SDK CLI Test Result shimin/add_node_concurrency

   12 files     12 suites   34m 50s ⏱️
  394 tests   386 ✅  8 💤 0 ❌
1 576 runs  1 544 ✅ 32 💤 0 ❌

Results for commit e95d6f9.

♻️ This comment has been updated with latest results.

@Jasmin3q Jasmin3q changed the title Support node_concurrency when running an async flow [Executor] Support node_concurrency when running an async flow Jan 10, 2024
@guming-learning guming-learning merged commit a3d2bb7 into main Jan 19, 2024
42 checks passed
@guming-learning guming-learning deleted the shimin/add_node_concurrency branch January 19, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thy09 thy09 thy09 approved these changes

@guming-learning guming-learning guming-learning approved these changes

Assignees
No one assigned
Labels
promptflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jasmin3q @thy09 @guming-learning