Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/alexcastroalex/add open api plugin support new endpoint for exposing open api manifest #2895

Conversation

AlexCastroAlex
Copy link

Description

Added OPEN API plugin support,

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@AlexCastroAlex
Copy link
Author

@microsoft-github-policy-service agree

@@ -122,7 +122,18 @@ def score():
def swagger():
"""Get the swagger object."""
return jsonify(app.swagger)


@app.route('/.well-known/ai-plugin.json', methods=['GET', 'OPTIONS'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, this may not work because the deployed endpoint has its own auth mechanism, you can't access this publicly. So we don't expect this to be part of the PF serving.

If you have requirement, either you can build your own serving app by inheriting the promptflow serving app, or you can build an extra plugin layer which sits before promptflow app.

Copy link
Author

@AlexCastroAlex AlexCastroAlex Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but i thought this would act as the swagger.json file but i think i misunderstood the use.
Anyway , exposing an OPEN API manifest is real needed feature because using propt flow as an open ai plugin factory is a real use case.

Copy link
Contributor

@wxpjimmy wxpjimmy Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

"exposing an OPEN API manifest is real needed feature because using propt flow as an open ai plugin factory is a real use case."

This is not the main targeting scenario of PF, we don't expect to provide this as a built-in functionality in PF serving, If you want this feature, we suggest you customize your own serving stack for this.

Copy link

github-actions bot commented May 7, 2024

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue/pull request label May 7, 2024
Copy link

Hi, thank you for your contribution. Since there has not been recent engagement, we are going to close this out. Feel free to reopen if you'd like to continue working on these changes. Please be sure to remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external no-recent-activity There has been no recent activity on this issue/pull request promptflow-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants