-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User/alexcastroalex/add open api plugin support new endpoint for exposing open api manifest #2895
Conversation
@microsoft-github-policy-service agree |
@@ -122,7 +122,18 @@ def score(): | |||
def swagger(): | |||
"""Get the swagger object.""" | |||
return jsonify(app.swagger) | |||
|
|||
|
|||
@app.route('/.well-known/ai-plugin.json', methods=['GET', 'OPTIONS']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, this may not work because the deployed endpoint has its own auth mechanism, you can't access this publicly. So we don't expect this to be part of the PF serving.
If you have requirement, either you can build your own serving app by inheriting the promptflow serving app, or you can build an extra plugin layer which sits before promptflow app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but i thought this would act as the swagger.json file but i think i misunderstood the use.
Anyway , exposing an OPEN API manifest is real needed feature because using propt flow as an open ai plugin factory is a real use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
"exposing an OPEN API manifest is real needed feature because using propt flow as an open ai plugin factory is a real use case."
This is not the main targeting scenario of PF, we don't expect to provide this as a built-in functionality in PF serving, If you want this feature, we suggest you customize your own serving stack for this.
Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. |
Hi, thank you for your contribution. Since there has not been recent engagement, we are going to close this out. Feel free to reopen if you'd like to continue working on these changes. Please be sure to remove the |
Description
Added OPEN API plugin support,
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines