-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Gen meta before update signatures #3195
Conversation
promptflow SDK CLI Azure E2E Test Result wanhan/fix_c_sharp_meta_generation 4 files 4 suites 4m 9s ⏱️ Results for commit ed8828b. ♻️ This comment has been updated with latest results. |
SDK CLI Global Config Test Result wanhan/fix_c_sharp_meta_generation6 tests 6 ✅ 1m 13s ⏱️ Results for commit ed8828b. ♻️ This comment has been updated with latest results. |
Executor Unit Test Result wanhan/fix_c_sharp_meta_generation792 tests 792 ✅ 3m 44s ⏱️ Results for commit ed8828b. ♻️ This comment has been updated with latest results. |
Executor E2E Test Result wanhan/fix_c_sharp_meta_generation243 tests 238 ✅ 5m 35s ⏱️ Results for commit ed8828b. ♻️ This comment has been updated with latest results. |
SDK CLI Test Result wanhan/fix_c_sharp_meta_generation 4 files 4 suites 1h 2m 25s ⏱️ Results for commit ed8828b. ♻️ This comment has been updated with latest results. |
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
This pull request includes changes that primarily focus on modifying the handling of flow variants and initial keyword arguments (
init_kwargs
) in thepromptflow-devkit
package. The most significant changes involve removing the usage ofProxyFactory
and itsprepare_metadata
method, addinginit_kwargs
parameter to various methods and functions, and modifying theflow_overwrite_context
function to accommodate these changes.Here are the key changes, grouped by their themes:
Removal of
ProxyFactory
:src/promptflow-devkit/promptflow/_sdk/_orchestrator/run_submitter.py
: Removed the import ofProxyFactory
and its usage in_submit_bulk_run
method. [1] [2]Changes to
init_kwargs
handling:src/promptflow-devkit/promptflow/_sdk/_orchestrator/run_submitter.py
: Addedinit_kwargs
as a parameter to theflow_overwrite_context
in the_run_bulk
method.src/promptflow-devkit/promptflow/_sdk/_orchestrator/test_submitter.py
: Addedinit_kwargs
as a parameter to the_resolve_variant
method and used it in theinit
method. Removed the usage ofProxyFactory
and itsprepare_metadata
method in theinit
method. [1] [2] [3]src/promptflow-devkit/promptflow/_sdk/_orchestrator/utils.py
: Addedinit_kwargs
as a parameter to theoverride_flow_yaml
andflow_overwrite_context
functions. Also, moved theprepare_metadata
method call to theoverride_flow_yaml
function. [1] [2] [3] [4]These changes seem to simplify the codebase by reducing the reliance on the
ProxyFactory
and itsprepare_metadata
method, and provide a more consistent way of handlinginit_kwargs
across different methods and functions.All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines