Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing timezone issue with local to cloud run #3361

Merged

Conversation

singankit
Copy link
Member

@singankit singankit commented May 31, 2024

Description

Local to cloud tracking has incorrect creation time as shown in screenshot below. This PR fixes this issue.
image

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented May 31, 2024

promptflow SDK CLI Azure E2E Test Result users/singankit/support_aggregated_metrics_if_flows_generate

  4 files    4 suites   4m 17s ⏱️
243 tests 203 ✅  40 💤 0 ❌
972 runs  812 ✅ 160 💤 0 ❌

Results for commit bdc732c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 31, 2024

SDK CLI Global Config Test Result users/singankit/support_aggregated_metrics_if_flows_generate

6 tests   6 ✅  1m 17s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit bdc732c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 31, 2024

Executor Unit Test Result users/singankit/support_aggregated_metrics_if_flows_generate

796 tests   796 ✅  3m 46s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit bdc732c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 31, 2024

Executor E2E Test Result users/singankit/support_aggregated_metrics_if_flows_generate

246 tests   240 ✅  5m 10s ⏱️
  1 suites    6 💤
  1 files      0 ❌

Results for commit bdc732c.

♻️ This comment has been updated with latest results.

luigiw
luigiw previously approved these changes May 31, 2024
Copy link

github-actions bot commented May 31, 2024

SDK CLI Test Result users/singankit/support_aggregated_metrics_if_flows_generate

    4 files      4 suites   1h 6m 40s ⏱️
  784 tests   764 ✅ 20 💤 0 ❌
3 136 runs  3 056 ✅ 80 💤 0 ❌

Results for commit bdc732c.

♻️ This comment has been updated with latest results.

@singankit singankit merged commit 43b1f6b into main Jun 11, 2024
41 checks passed
@singankit singankit deleted the users/singankit/support_aggregated_metrics_if_flows_generate branch June 11, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants