Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setuptools as an explicit dependency for now. #3393

Closed
wants to merge 1 commit into from

Conversation

nick863
Copy link
Contributor

@nick863 nick863 commented Jun 7, 2024

Description

Fix the issue with the pkg_resources not being find. See work item 3202015.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@nick863 nick863 requested a review from a team as a code owner June 7, 2024 23:25
Copy link

github-actions bot commented Jun 7, 2024

promptflow-evals test result

  9 files  ±0    9 suites  ±0   1h 26m 39s ⏱️ - 2m 53s
 39 tests ±0   35 ✅ ±0   4 💤 ±0  0 ❌ ±0 
351 runs  ±0  315 ✅ ±0  36 💤 ±0  0 ❌ ±0 

Results for commit 084e70d. ± Comparison against base commit 96dbf33.

♻️ This comment has been updated with latest results.

@microsoft microsoft deleted a comment Jun 8, 2024
@nick863
Copy link
Contributor Author

nick863 commented Jun 11, 2024

This PR is not needed because explicit mlflow dependency was removed.

@nick863 nick863 closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant