-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the promptflow-azure dependency #3403
base: main
Are you sure you want to change the base?
Conversation
…irovins/remove_mlflow_dep
…irovins/remove_mlflow_dep
…irovins/remove_mlflow_dep
promptflow-evals test result 12 files + 3 12 suites +3 17m 36s ⏱️ - 1h 50m 57s Results for commit 901ce3b. ± Comparison against base commit 08cc0d4. This pull request removes 52 and adds 89 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
numpy = ">=1.22" | ||
promptflow-azure = { version = "<2.0.0", optional = true} # Needed for remote tracking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this if customer will see error message that tells them to install pf-azure ?
local_paths = [] | ||
|
||
# Go over the artifact folder and upload all artifacts. | ||
for (root, _, filenames) in os.walk(artifact_folder): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not expecting it to have more than one file right ?
container=datastore.container_name, | ||
blob=remote['path']) | ||
with open(local, 'rb') as fp: | ||
blob_client.upload_blob(fp, overwrite=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this logic exist in pf-azure. Would it be beneficial to reuse it ?
Description
Remove the promptflow-azure dependency from the promptflow-evals. We mostly use it to authenticate to azure, in tests, the runs are now obtained by using the RunHistory.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines