Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass subscription/resource_group/workspace settings define in customer folder repo to PF SDK #3406

Merged
merged 6 commits into from
Jun 14, 2024

Conversation

linningmii
Copy link
Member

Description

Pass subscription/resource_group/workspace settings in the config file to the _retrieve_tool_func_result function call to fix #2876. There's another PR to read related files in the vscode extension repo.

image

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

promptflow SDK CLI Azure E2E Test Result zholin/workspace-passing

  4 files    4 suites   4m 20s ⏱️
243 tests 203 ✅  40 💤 0 ❌
972 runs  812 ✅ 160 💤 0 ❌

Results for commit f944b81.

Copy link

SDK CLI Global Config Test Result zholin/workspace-passing

6 tests   6 ✅  1m 19s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit f944b81.

Copy link

Executor Unit Test Result zholin/workspace-passing

796 tests   796 ✅  3m 47s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit f944b81.

Copy link

Executor E2E Test Result zholin/workspace-passing

246 tests   240 ✅  5m 3s ⏱️
  1 suites    6 💤
  1 files      0 ❌

Results for commit f944b81.

Copy link

SDK CLI Test Result zholin/workspace-passing

    4 files      4 suites   1h 7m 12s ⏱️
  784 tests   764 ✅ 20 💤 0 ❌
3 136 runs  3 056 ✅ 80 💤 0 ❌

Results for commit f944b81.

@linningmii linningmii merged commit 4f542cd into main Jun 14, 2024
41 checks passed
@linningmii linningmii deleted the zholin/workspace-passing branch June 14, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [VSCode Extension] VectorDB Index Lookup doesn't take the config.json variables into consideration
5 participants