-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[devkit][bugfix] Add check for trace.NoOpTracerProvider
to avoid crash
#3407
Conversation
promptflow SDK CLI Azure E2E Test Result zhengfei/bugfix/mlflow-tracing-disable 4 files 4 suites 4m 18s ⏱️ Results for commit c5885ab. |
SDK CLI Global Config Test Result zhengfei/bugfix/mlflow-tracing-disable6 tests 6 ✅ 1m 19s ⏱️ Results for commit c5885ab. |
Executor Unit Test Result zhengfei/bugfix/mlflow-tracing-disable796 tests 796 ✅ 3m 46s ⏱️ Results for commit c5885ab. |
Executor E2E Test Result zhengfei/bugfix/mlflow-tracing-disable246 tests 240 ✅ 5m 3s ⏱️ Results for commit c5885ab. |
SDK CLI Test Result zhengfei/bugfix/mlflow-tracing-disable 4 files 4 suites 1h 7m 27s ⏱️ Results for commit c5885ab. ♻️ This comment has been updated with latest results. |
Description
In some cases (we have observed in runtime scenario, related to mlflow), tracer provider can be set as
trace.NoOpTracerProvider
, which does not have methodadd_span_processor
and lead to error. This PR adds a check on that to avoid such crash.All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines