Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devkit][bugfix] Add check for trace.NoOpTracerProvider to avoid crash #3407

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented Jun 12, 2024

Description

In some cases (we have observed in runtime scenario, related to mlflow), tracer provider can be set as trace.NoOpTracerProvider, which does not have method add_span_processor and lead to error. This PR adds a check on that to avoid such crash.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

promptflow SDK CLI Azure E2E Test Result zhengfei/bugfix/mlflow-tracing-disable

  4 files    4 suites   4m 18s ⏱️
243 tests 203 ✅  40 💤 0 ❌
972 runs  812 ✅ 160 💤 0 ❌

Results for commit c5885ab.

Copy link

SDK CLI Global Config Test Result zhengfei/bugfix/mlflow-tracing-disable

6 tests   6 ✅  1m 19s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit c5885ab.

Copy link

Executor Unit Test Result zhengfei/bugfix/mlflow-tracing-disable

796 tests   796 ✅  3m 46s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit c5885ab.

Copy link

Executor E2E Test Result zhengfei/bugfix/mlflow-tracing-disable

246 tests   240 ✅  5m 3s ⏱️
  1 suites    6 💤
  1 files      0 ❌

Results for commit c5885ab.

Copy link

github-actions bot commented Jun 12, 2024

SDK CLI Test Result zhengfei/bugfix/mlflow-tracing-disable

    4 files      4 suites   1h 7m 27s ⏱️
  785 tests   765 ✅ 20 💤 0 ❌
3 140 runs  3 060 ✅ 80 💤 0 ❌

Results for commit c5885ab.

♻️ This comment has been updated with latest results.

@zhengfeiwang zhengfeiwang merged commit 745704a into main Jun 12, 2024
41 checks passed
@zhengfeiwang zhengfeiwang deleted the zhengfei/bugfix/mlflow-tracing-disable branch June 12, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants