Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Fix tool ci by skipping acs test since the test resource is not valid #3423

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

16oeahr
Copy link
Contributor

@16oeahr 16oeahr commented Jun 17, 2024

Description

Failed tool ci: https://github.com/microsoft/promptflow/actions/runs/9542727564/job/26298045963

FAILED src/promptflow-tools/tests/test_acs.py::TestAzureContentSafety::test_azure_content_safety_analyze_happy_path - promptflow.tools.exception.AzureContentSafetySystemError: Error in detecting content: Key based authentication is disabled for this resource.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@16oeahr 16oeahr requested a review from a team as a code owner June 17, 2024 06:19
@github-actions github-actions bot added the promptflow-tools promptflow tools code label Jun 17, 2024
@16oeahr 16oeahr merged commit 36883b4 into main Jun 17, 2024
11 checks passed
@16oeahr 16oeahr deleted the user/yalu4/fix_tool_ci branch June 17, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
promptflow-tools promptflow tools code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants