Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fundamental][bugfix] Pin tenacity<8.4.0 to fix import-linter CI #3424

Merged
merged 7 commits into from
Jun 17, 2024

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented Jun 17, 2024

Description

Pin tenacity to avoid issue described in langchain-ai/langchain#22972.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@zhengfeiwang zhengfeiwang requested a review from a team as a code owner June 17, 2024 08:51
@zhengfeiwang zhengfeiwang changed the title pin tenacity<8.4.0 [fundamental][bugfix] Pin tenacity<8.4.0 to fix import-linter CI Jun 17, 2024
Copy link

github-actions bot commented Jun 17, 2024

Executor Unit Test Result zhengfei/bugfix/tenacity-import-linter

795 tests   794 ✅  3m 47s ⏱️
  1 suites    0 💤
  1 files      0 ❌  1 🔥

For more details on these errors, see this check.

Results for commit 449312f.

♻️ This comment has been updated with latest results.

@Wicky-np
Copy link

hi i am building a RAG pipe line and facing the same issue there ModuleNotFoundError: No module named 'tenacity.asyncio'
and the version 8.1.0 is not compatible with langchain new update

@zhengfeiwang
Copy link
Contributor Author

hi i am building a RAG pipe line and facing the same issue there ModuleNotFoundError: No module named 'tenacity.asyncio' and the version 8.1.0 is not compatible with langchain new update

I'm trying to ignore the latest tenacity as seems that's where the breaking comes out, but I'm trying to recall my knowledge with poetry... might need some trials to get this PR merged.

@Wicky-np
Copy link

Wicky-np commented Jun 17, 2024

used the version 8.3.0 issue was fixed thanks alot guys

Copy link

Executor E2E Test Result zhengfei/bugfix/tenacity-import-linter

246 tests   237 ✅  5m 3s ⏱️
  1 suites    6 💤
  1 files      3 ❌

For more details on these failures, see this check.

Results for commit 449312f.

@zhengfeiwang zhengfeiwang merged commit 01267fd into main Jun 17, 2024
18 of 22 checks passed
@zhengfeiwang zhengfeiwang deleted the zhengfei/bugfix/tenacity-import-linter branch June 17, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants