Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show user friendly error message for multi-process boostrapping error #3426

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

ninghu
Copy link
Member

@ninghu ninghu commented Jun 17, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ninghu ninghu changed the title Print a user friendly error message for multiprocessing main entry guard Show main entry guard message for multi-process boostrapping error Jun 17, 2024
@ninghu ninghu changed the title Show main entry guard message for multi-process boostrapping error Show user friendly error message for multi-process boostrapping error Jun 17, 2024
Copy link

github-actions bot commented Jun 17, 2024

promptflow-evals test result

  9 files    9 suites   2h 34m 30s ⏱️
 52 tests  47 ✅  5 💤 0 ❌
468 runs  423 ✅ 45 💤 0 ❌

Results for commit 57b5f05.

♻️ This comment has been updated with latest results.

@ninghu ninghu marked this pull request as ready for review June 17, 2024 21:36
@ninghu ninghu requested a review from a team as a code owner June 17, 2024 21:36
@singankit singankit merged commit 2e6746a into main Jun 18, 2024
37 checks passed
@singankit singankit deleted the users/ninhu/main_entry_guard branch June 18, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants