Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fundamental][bugfix] Replace retired model "text-ada-001" #3429

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented Jun 18, 2024

Description

"text-ada-001" retires in 6/18 (reference: https://learn.microsoft.com/en-us/azure/ai-services/openai/concepts/model-retirements#deprecated-models), this PR replaces it with the suggested model.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@zhengfeiwang zhengfeiwang requested a review from a team as a code owner June 18, 2024 06:35
@zhengfeiwang zhengfeiwang marked this pull request as draft June 18, 2024 06:35
@zhengfeiwang zhengfeiwang changed the title replace retired model [fundamental][bugfix] Replace retired model "text-ada-001" Jun 18, 2024
Copy link

github-actions bot commented Jun 18, 2024

promptflow SDK CLI Azure E2E Test Result zhengfei/bugfix/executor-ci-0618

  4 files    4 suites   4m 17s ⏱️
243 tests 203 ✅  40 💤 0 ❌
972 runs  812 ✅ 160 💤 0 ❌

Results for commit 995dc7c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 18, 2024

SDK CLI Global Config Test Result zhengfei/bugfix/executor-ci-0618

6 tests   6 ✅  1m 14s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 995dc7c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 18, 2024

Executor Unit Test Result zhengfei/bugfix/executor-ci-0618

796 tests   796 ✅  3m 47s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 995dc7c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 18, 2024

Executor E2E Test Result zhengfei/bugfix/executor-ci-0618

246 tests   240 ✅  5m 18s ⏱️
  1 suites    6 💤
  1 files      0 ❌

Results for commit 995dc7c.

♻️ This comment has been updated with latest results.

Copy link

SDK CLI Test Result zhengfei/bugfix/executor-ci-0618

    4 files      4 suites   1h 7m 34s ⏱️
  786 tests   766 ✅ 20 💤 0 ❌
3 144 runs  3 064 ✅ 80 💤 0 ❌

Results for commit 995dc7c.

@wangchao1230 wangchao1230 merged commit 08cc0d4 into main Jun 18, 2024
41 checks passed
@wangchao1230 wangchao1230 deleted the zhengfei/bugfix/executor-ci-0618 branch June 18, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants