Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helper macros for multiple signatures #96

Merged
merged 3 commits into from
May 13, 2024

Conversation

mingxwa
Copy link
Collaborator

@mingxwa mingxwa commented May 12, 2024

When defining a dispatch with multiple signatures, the behavior is not well-defined in the standard when there are multiple commas (",") in the expansion. This has confirmed to be a regression since 2.3.0.

Resolves #97

@mingxwa mingxwa assigned tian-lt and guominrui and unassigned tian-lt and guominrui May 12, 2024
@mingxwa mingxwa requested review from tian-lt and guominrui May 12, 2024 05:45
@mingxwa mingxwa marked this pull request as ready for review May 12, 2024 05:45
@mingxwa mingxwa merged commit 32aba26 into microsoft:main May 13, 2024
4 checks passed
@mingxwa mingxwa deleted the user/mingxwa/macro-regression branch May 13, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helper macros fail to expand for multiple signatures in GCC/clang
3 participants