Support for TIFF format in Depth Compression #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chitsaw
requested changes
Jul 24, 2021
Sources/Imaging/Microsoft.Psi.Imaging.Windows/DepthImageFromTiffStreamDecoder.cs
Outdated
Show resolved
Hide resolved
Sources/Imaging/Microsoft.Psi.Imaging.Windows/DepthImageCompressor.cs
Outdated
Show resolved
Hide resolved
Sources/Imaging/Microsoft.Psi.Imaging.Linux/DepthImageCompressor.cs
Outdated
Show resolved
Hide resolved
|
Thanks for the review. I just made the suggested changes. |
chitsaw
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add the support to encode/decode depth image with TIFF compression format. TIFF format has been used in application such as ROS to encode depth images. The code/design for this PR is based on the PNG encoder/decoder.
Changes:
Let me know if any changes are required