Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

adapter: access tokens #1711

Closed
int19h opened this issue Aug 22, 2019 · 0 comments
Closed

adapter: access tokens #1711

int19h opened this issue Aug 22, 2019 · 0 comments
Assignees
@int19h
Labels
area:Connection

Comments

@int19h
Copy link
Contributor

int19h commented Aug 22, 2019

Adapter should implement the counterpart to #1710 in pydevd. This includes:

  1. A command line argument that allows to specify the server access token (used by ptvsd in enable_attach() mode).
  2. Generation of a cryptographically secure client access token.
  3. Passing the server token to pydevd in the "initialize" request when connecting.
  4. Verifying that the client token returned by pydevd in the "initialize" response matches the generated client token.
@int19h int19h mentioned this issue Aug 22, 2019
Closed
@Anapo14 Anapo14 added this to the September 2019.1 milestone Sep 4, 2019
@gramster gramster removed this from the Sep 2019.1 milestone Sep 10, 2019
fabioz added a commit to fabioz/ptvsd that referenced this issue Sep 17, 2019
@fabioz
Provide api to launch python executable without subprocess patching. F…
35110d4 
…ixes microsoft#1711
@int19h int19h closed this as completed in b7c48cc Oct 1, 2019
@karthiknadig karthiknadig reopened this Oct 1, 2019
@int19h int19h self-assigned this Oct 3, 2019
int19h added a commit to int19h/ptvsd that referenced this issue Dec 9, 2019
@int19h
Fix microsoft#1711: adapter: access tokens
1524da1 
Generate server access token in enable_attach(), propagate it to the adapter, and have the adapter authenticate to the server via "pydevdAuthorize".

Fix pydevd to correctly propagate access tokens for subprocesses that are not forked.
int19h added a commit to int19h/ptvsd that referenced this issue Dec 9, 2019
@int19h
Fix microsoft#1711: adapter: access tokens
819cf41 
Generate server access token in enable_attach(), propagate it to the adapter, and have the adapter authenticate to the server via "pydevdAuthorize".

Generate client access token in adapter when not spawned by server, and propagate it to pydevd.

Fix pydevd to correctly propagate access tokens for subprocesses that are not forked.
int19h added a commit to int19h/ptvsd that referenced this issue Dec 11, 2019
@int19h
Fix microsoft#1711: adapter: access tokens
f1f065c 
Generate server access token in enable_attach(), propagate it to the adapter, and have the adapter authenticate to the server via "pydevdAuthorize".

Generate client access token in adapter when not spawned by server, and propagate it to pydevd.

Fix pydevd to correctly propagate access tokens for subprocesses that are not forked.
@int19h int19h closed this as completed in 0d79c16 Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@int19h int19h

Labels
area:Connection
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@int19h @gramster @karthiknadig @Anapo14