Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Set SIO_LOOPBACK_FAST_PATH while creating socket in windows #913

Merged
merged 3 commits into from
Oct 23, 2018

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Oct 12, 2018

Fixes #912, #949

@int19h is the try/catch the right way to do this? Do we need to create a new socket in place of pass?

@int19h
Copy link
Contributor

int19h commented Oct 12, 2018

I think it should be safe to proceed with the socket - it oughtn't be invalidated by a failed ioctl.

Also, you might as well just catch AttributeError instead of doing hasattr!

@codecov-io
Copy link

codecov-io commented Oct 15, 2018

Codecov Report

Merging #913 into master will decrease coverage by 0.12%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #913      +/-   ##
==========================================
- Coverage   55.51%   55.38%   -0.13%     
==========================================
  Files          33       33              
  Lines        4395     4407      +12     
==========================================
+ Hits         2440     2441       +1     
- Misses       1955     1966      +11
Impacted Files Coverage Δ
ptvsd/socket.py 59.13% <25%> (-3.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 182683b...c674803. Read the comment docs.

@karthiknadig karthiknadig changed the title [Discussion] Set SIO_LOOPBACK_FAST_PATH while creating socket in windows Set SIO_LOOPBACK_FAST_PATH while creating socket in windows Oct 15, 2018
@karthiknadig karthiknadig reopened this Oct 22, 2018
@karthiknadig karthiknadig merged commit 1844dfb into microsoft:master Oct 23, 2018
@karthiknadig karthiknadig deleted the issue912 branch October 23, 2018 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants