Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiles get swapped in code #3026

Closed
livcheerful opened this issue Feb 1, 2021 · 3 comments · Fixed by microsoft/pxt#7858
Closed

Tiles get swapped in code #3026

livcheerful opened this issue Feb 1, 2021 · 3 comments · Fixed by microsoft/pxt#7858
Assignees
Labels
bug Something isn't working next-release p2

Comments

@livcheerful
Copy link
Contributor

Describe the bug
I was working on this project and editing tiles when I started seeing the tile conditionals return incorrectly. On my screen the tiles were correct, but after refreshing the page or sharing it with someone else, the tiles were secretly wrong

My screen:
image

What it actually was:
image

Joey pointed out that a user was also hitting this
https://forum.makecode.com/t/help-plz/5878/5

To Reproduce
No great repro yet, when I made the tilemap I was doing a bunch of duplicating / editing / reediting of tiles, so I'll keep trying to do that to repro...

Desktop (please complete the following information):

  • OS: Windows
  • Browser Chrome 86
@jwunderl
Copy link
Member

jwunderl commented Feb 1, 2021

For reference here's the share link that I received / noticed the error in: https://makecode.com/_Xpob83JAUUCh I would suspect there's a duplicate internalId or something in the assets files~

@jwunderl
Copy link
Member

jwunderl commented Feb 1, 2021

Ahh yeah it looks like it is:
image

tiles8-13 are duplicated in the switch case

@jwunderl jwunderl added bug Something isn't working next-release labels Feb 1, 2021
@abchatra abchatra added the p2 label Feb 2, 2021
@jwunderl
Copy link
Member

jwunderl commented Feb 3, 2021

Easy repro: drag out tilemap block, open and make 3 custom tiles, go to asset editor, make custom tile, go to tilemap.g.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next-release p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants