Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proof of concept cloud-compiled share page #1274

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

mmoskal
Copy link
Member

@mmoskal mmoskal commented Sep 1, 2019

Requires microsoft/pxt#5858
Go to say http://localhost:3232/70131-58277-87184-36217 to test it (after rebuilding pxt, and re-rerunning pxt serve --rebundle)

  • while the splash page is up, we are already loading simulator and compiled code in background
  • the reset button goes back to the splash page

TODO:

  • styling for splash page
  • add Play button over script thumbnail
  • abuse report UI
  • do we want to use semantic UI in here?
  • prevent control.reset() from going to the splash page
  • the cloud script APIs should indicate if there is a thumb nail and we should use that when rendering this page

@mmoskal
Copy link
Member Author

mmoskal commented Sep 1, 2019

@riknoll you may want to use this for your control update (or maybe not, not sure). It has less layers than the usual share page.

@pelikhan
Copy link
Member

pelikhan commented Sep 1, 2019

Semantic UI is bloated - let’s keep this page lean

@mmoskal mmoskal requested a review from shakao September 3, 2019 03:09
@mmoskal
Copy link
Member Author

mmoskal commented Sep 3, 2019

test page: https://arcade.staging.pxt.io/37372-65194-89912-62054

@shakao maybe you want to take a stab at styling this? Right now it looks seriously ugly, but is very responsive. It's easy to test locally - see top comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants