list extensions to build hexfiles for in staticpkg #3888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riknoll
approved these changes
Sep 1, 2021
abchatra
reviewed
Sep 1, 2021
pxtarget.json
Outdated
| "libs/hw", | ||
| "libs/hw---n3", | ||
| "libs/hw---n4", | ||
| "libs/hw---rpi", |
There was a problem hiding this comment.
Can we skip RPI or anything which is not popular?
There was a problem hiding this comment.
Could also remove hw---n4. I assume no board is using it today? Microbit is hw---n3 right? @mmoskal
There was a problem hiding this comment.
You probably don’t have to build cpp extensions for rpi but I think people on forum are using it in general. I don’t think there is any hw in production with n4. N3 is indeed micro bit.
abchatra
approved these changes
Sep 2, 2021
jwunderl
added a commit
that referenced
this pull request
Sep 2, 2021
* add staticpkgdirs to pxtarget.json * alphabetically sort bundleddirs, staticpkgdirs * split up staticpkgdirs to include base pkgs * cull a few extensions / vm from hex combo building * don't build combo hexes for rpi * drop n4
jwunderl
added a commit
that referenced
this pull request
Sep 2, 2021
* add staticpkgdirs to pxtarget.json * alphabetically sort bundleddirs, staticpkgdirs * split up staticpkgdirs to include base pkgs * cull a few extensions / vm from hex combo building * don't build combo hexes for rpi * drop n4
anzhou5
added a commit
that referenced
this pull request
Sep 4, 2021
* Added SC initial map information (#3866) * added initial SC map info - UNTESTED (need to install some stuff on this device first) * bolded time for each session * Updated teacher docs and the SC title (#3867) * Kiki lee rockstar1 (#3871) * Update Maze Levels * Updated rockstar2 * Added anigifs (#3872) * Experimenting with options... (#3873) * add crowdin ignore for sc (#3875) * Merging the Rockstar maze (#3879) * Merging the Rockstar maze * Changed some wording * Tiny changes (#3882) * Added help hover text for SC blocks & debugged (#3890) * Bump pxt-core to 7.2.8 (#3892) * 1.6.5 * Temporarily pin beta ref to release version (#3893) * Revert "Temporarily pin beta ref to release version (#3893)" (#3894) This reverts commit 7f5a746. * list extensions to build hexfiles for in staticpkg (#3888) * add staticpkgdirs to pxtarget.json * alphabetically sort bundleddirs, staticpkgdirs * split up staticpkgdirs to include base pkgs * cull a few extensions / vm from hex combo building * don't build combo hexes for rpi * drop n4 * Bump pxt-core to 7.2.9 (#3897) * 1.6.6 * fixed SC tile blocks Co-authored-by: Kiki Prottsman <kiki-lee@users.noreply.github.com> Co-authored-by: Joey Wunderlich <jwunderl@users.noreply.github.com> Co-authored-by: shakao <34112083+shakao@users.noreply.github.com> Co-authored-by: shakao <shakao@microsoft.com> Co-authored-by: Abhijith Chatra <abchatra@microsoft.com>
eanders-ms
added a commit
that referenced
this pull request
Sep 13, 2021
* Bumping pxt-core to 7.1.26 and common-packages to 9.1.5 * 1.5.47 * Bumping pxt-croe to 7.1.27 * 1.5.48 * [stable1.5]Add skillmap logo to assets path (#3850) * Add skillmap logo to assets path * Add Cloud User Icon for modal * 1.5.49 * Bumping pxt-core to 7.1.29 * 1.5.50 * list extensions to build hexfiles for in staticpkg (#3888) (#3896) * add staticpkgdirs to pxtarget.json * alphabetically sort bundleddirs, staticpkgdirs * split up staticpkgdirs to include base pkgs * cull a few extensions / vm from hex combo building * don't build combo hexes for rpi * drop n4 * [stable1.5] bump pxt-core (#3899) * 1.5.51 * [stable1.5] Bumping pxt-core to 7.1.31 (#3919) * 1.5.52 * Bumping pxt-core to 7.1.32 * 1.5.53 * Bump pxt-arcade-sim to v0.8.6 (#3936) * Bumping pxt-core to 7.1.33 (#3938) * 1.5.54 * Bumping pxt-core to 7.1.34 * 1.5.55 * Bumping pxt-core to 7.1.35 * 1.5.56 Co-authored-by: Abhijith Chatra <abchatra@microsoft.com> Co-authored-by: Vivian Li <vivl@microsoft.com> Co-authored-by: Joey Wunderlich <jwunderl@users.noreply.github.com> Co-authored-by: Joey Wunderlich <joey.wunderlich@gmail.com> Co-authored-by: Vivian Li <li.v.cheerful@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: microsoft/pxt#8460
With this looks like staticpkg build time is ~~ 20-30minutes again.
I went ahead and sorted the lists in c21fec4 as it was getting way too hard to compare what was in them / keep track of where things were.