Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix case in path #285

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix case in path #285

merged 1 commit into from
Apr 29, 2024

Conversation

Amerlander
Copy link
Collaborator

This time, there's a snag, the CI was failing because the case of the icon path was wrong.

@abchatra could you merge this fix and bump. I'm sorry for that mistake.

@abchatra abchatra merged commit 2f85689 into microsoft:master Apr 29, 2024
4 checks passed
@Amerlander
Copy link
Collaborator Author

@abchatra the CI still fails. This time it seems to be an issue within Crowdin: Requested project doesn't exist or the API key is invalid

executing Crowdin command upload...
upload calliopemini/target-strings.json (60 strings) to https://crowdin.com/project/makecode
INTERNAL ERROR: Error: Error, upload translation: calliopemini/target-strings.json, 404, {
    "success": false,
    "error": {
        "code": 1,
        "message": "Requested project doesn't exist or the API key is invalid"
    }
}

I'm not sure where to fix this, can you take a look?

@abchatra
Copy link
Contributor

@riknoll help please

@riknoll
Copy link
Member

riknoll commented Apr 30, 2024

@Amerlander we recently upgraded to using crowdin's v2 APIs because crowdin finally shut down their v1 APIs. I've opened a PR to cherry pick the changes over to the version of pxt-core you're using:

microsoft/pxt#9991

Once that is merged, you'll want to update the pxt-core version you have in package.json to get the new crowdin changes

@riknoll
Copy link
Member

riknoll commented Apr 30, 2024

@Amerlander should be fixed now. Make sure to merge master!

@riknoll
Copy link
Member

riknoll commented Apr 30, 2024

eh, actually looks like it's uploading now but it has hit a snag with one of the filenames. i'll investigate

@riknoll
Copy link
Member

riknoll commented Apr 30, 2024

fixed and bumped!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants