Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulator embed is broken #2152

Closed
riknoll opened this issue Jun 7, 2019 · 1 comment · Fixed by microsoft/pxt#5659
Closed

Simulator embed is broken #2152

riknoll opened this issue Jun 7, 2019 · 1 comment · Fixed by microsoft/pxt#5659
Labels
bug next-release P2

Comments

@riknoll
Copy link
Member

riknoll commented Jun 7, 2019

To reproduce:

  1. Share a script
  2. Expand the embed options
  3. Select simulator
  4. Copy+paste into jsfiddle
  5. Observe as it loads forever

In the console I get and error that says can't call getAttribute() on null. Maybe related to @ChaseMor changes?
@riknoll riknoll added the bug label Jun 7, 2019
@abchatra
Copy link
Contributor

abchatra commented Jun 7, 2019

@ChaseMor this looks like a regression from your change. Please take a look

@ChaseMor ChaseMor mentioned this issue Jun 10, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
@lock lock bot unassigned ChaseMor Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug next-release P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add check to see if frameElement exists ChaseMor/pxt
3 participants
@abchatra @ChaseMor @riknoll