Bumped CODAL target version up to v0.2.57 as a hotfix #5324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue for this is being tracked here: lancaster-university/codal-microbit-v2#355 and we think this patch is good to go. Removed the DO NOT MERGE label |
jwunderl
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
diffs for reference:
- lancaster-university/codal-microbit-v2@v0.2.56...v0.2.57
- lancaster-university/codal-core@763a2d1...2658178
code diffs look fine to me, will prep a stable version. Thanks for handling this so quickly!
jwunderl
pushed a commit
that referenced
this pull request
Jul 25, 2023
jwunderl
added a commit
that referenced
this pull request
Jul 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily marked as DO NOT MERGE while we run tests, but happy to merge once everything is verified as OK.