Add list of unsupported browsers to pxttarget json (#5687)

* Add browser blacklist to pxttarget json * Null check for blacklist * Rename to unsupportedBrowsers * Move to AppTarget * Reformat to be object * Remove reference from comment
microsoft · Jun 19, 2019 · 7030618 · 7030618
1 parent 98da547
commit 7030618
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/localtypings/pxtarget.d.ts b/localtypings/pxtarget.d.ts
@@ -49,6 +49,11 @@ declare namespace pxt {
         ignoreDocsErrors?: boolean;
         variants?: Map<AppTarget>; // patches on top of the current AppTarget for different chip variants
         queryVariants?: Map<AppTarget>; // patches on top of the current AppTarget using query url regex
+        unsupportedBrowsers?: BrowserOptions[] // list of unsupported browsers for a specific target (eg IE11 in arcade). check browserutils.js browser() function for strings
+    }
+
+    interface BrowserOptions {
+        id: string;
     }
 
     interface ProjectTemplate {

diff --git a/pxtlib/browserutils.ts b/pxtlib/browserutils.ts
@@ -218,6 +218,11 @@ namespace pxt.BrowserUtils {
         if (/bot|crawler|spider|crawling/i.test(navigator.userAgent))
             return true;
 
+        //Check target theme to see if this browser is supported
+        if (pxt.appTarget.unsupportedBrowsers && pxt.appTarget.unsupportedBrowsers.some(b => b.id == browser())) {
+            return false
+        }
+
         // testing browser versions
         const versionString = browserVersion();
         const v = parseInt(versionString || "0")