Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when trying to carry over code without a template code block #10020

Merged
merged 2 commits into from
May 23, 2024

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented May 23, 2024

Fixes microsoft/pxt-arcade#6386

When you try to carry code between skillmap steps, we refuse to import the old code if the destination tutorial doesn't have a template code block. This behavior was confusing to content authors, so adding an explicit warning to the console to hopefully make everything a little more discoverable. Check out the forum thread in the linked issue for more info.

@riknoll riknoll requested review from kiki-lee and a team May 23, 2024 23:47
@riknoll riknoll merged commit 03047d2 into master May 23, 2024
6 checks passed
@riknoll riknoll deleted the dev/riknoll/code-carryover-warning branch May 23, 2024 23:59
@kiki-lee
Copy link
Contributor

Great find!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Code Not Carrying Over in Skillmap
3 participants