Add support for different codal message bus listener flags #10054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2024
srietkerk
reviewed
Jul 26, 2024
| @@ -563,13 +571,43 @@ namespace pxsim { | |||
|
|
|||
| export type EventIDType = number | string; | |||
|
|
|||
| class EventHandler { | |||
| private busy = 0; | |||
| constructor(public handler: RefAction, public flags: number) {} | |||
There was a problem hiding this comment.
This is a bit pedantic, but wondering if the flags parameter will be able to pass on multiple flags or just one at a time since it has type number?
There was a problem hiding this comment.
i'm matching the codal naming here, but actually numbers can hold up to 32 flags (one for each bit)
srietkerk
reviewed
Jul 26, 2024
| @@ -3,6 +3,14 @@ | |||
| namespace pxsim { | |||
| const MIN_MESSAGE_WAIT_MS = 200; | |||
| let tracePauseMs = 0; | |||
|
|
|||
| enum MessageListenerFlags { | |||
There was a problem hiding this comment.
Just wanted to put this here for reference: https://github.com/lancaster-university/codal-core/blob/509086cc8590465041b15493ab52b56e7071c110/inc/core/CodalListener.h#L33-L41
Also, just wanted to know why we're not including all of the defined flags here?
There was a problem hiding this comment.
those other ones are internal only AFAIK
Co-authored-by: Sarah Rietkerk <49178322+srietkerk@users.noreply.github.com>
jwunderl
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds simulator support for the various CODAL message bus listener modes. These modes are:
this is part of the fix for microsoft/pxt-microbit#5709, i'll have two more prs (one in pxt-common-packages and one in pxt-microbit)