Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

microbit v1 support #4373

Merged
merged 5 commits into from May 29, 2018
Merged

microbit v1 support #4373

merged 5 commits into from May 29, 2018

Conversation

mmoskal
Copy link
Member

@mmoskal mmoskal commented May 28, 2018

  • don't flash sources on the device for .hex targets (there's no read-back there anyway)
  • stop creating dal.d.ts except when pxt builddaldts
  • some ARM peephole improvements
  • fixes for size stats

@mmoskal mmoskal mentioned this pull request May 28, 2018
Merged
pelikhan
pelikhan approved these changes May 28, 2018
View reviewed changes
Copy link
Member

@pelikhan pelikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need tests for the packed sources support? Can we import those .hex files back in the editor?

pelikhan
pelikhan approved these changes May 28, 2018
View reviewed changes
Copy link
Member

@pelikhan pelikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this impact importing of .hex files?

@mmoskal
Copy link
Member Author

mmoskal commented May 28, 2018

They should work as is - the sources are still there, but behind the "end of file" marker, so daplink doesn't read them. Need to test though.

@pelikhan pelikhan merged commit 88ec644 into master May 29, 2018
@pelikhan pelikhan deleted the mbtag branch May 29, 2018 20:43
@lock
Copy link

lock bot commented Sep 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pelikhan pelikhan pelikhan approved these changes

@samelhusseini samelhusseini samelhusseini approved these changes

@tballmsft tballmsft Awaiting requested review from tballmsft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmoskal @pelikhan @samelhusseini