New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flipping and rotating to the image/tilemap/animation editor #7810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add flip/rotate icons, hook up to commands * Generalize button titles for tilemaps
riknoll
requested review from
jwunderl,
abchatra,
livcheerful,
soniakandah and
shakao
January 21, 2021 00:45
jwunderl
approved these changes
Jan 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! LGTM
|
||
const newImage = isTilemap ? new pxt.sprite.Tilemap(source.image.height, source.image.width) : | ||
new pxt.sprite.Bitmap(source.image.height, source.image.width); | ||
const newOverlayLayers = source.overlayLayers ? source.overlayLayers.map(layer => new pxt.sprite.Bitmap(layer.height, layer.width)) : undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
const newOverlayLayers = source.overlayLayers ? source.overlayLayers.map(layer => new pxt.sprite.Bitmap(layer.height, layer.width)) : undefined; | |
const newOverlayLayers = source.overlayLayers?.map(layer => new pxt.sprite.Bitmap(layer.height, layer.width)); |
optional nit
|
||
const newImage = isTilemap ? new pxt.sprite.Tilemap(source.image.width, source.image.height) : | ||
new pxt.sprite.Bitmap(source.image.width, source.image.height); | ||
const newOverlayLayers = source.overlayLayers ? source.overlayLayers.map(layer => new pxt.sprite.Bitmap(layer.width, layer.height)) : undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
const newOverlayLayers = source.overlayLayers ? source.overlayLayers.map(layer => new pxt.sprite.Bitmap(layer.width, layer.height)) : undefined; | |
const newOverlayLayers = source.overlayLayers?.map(layer => new pxt.sprite.Bitmap(layer.width, layer.height)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What....? Could it be....?? IT IS!!! Flip and rotate are finally in the image editor!!!!!
They both work basically like you would expect. If you select something with the marquee tool, then only that part of the image is flipped/rotated. Other random things:
And the new keyboard shortcuts:
All of this is pretty self contained (except the buttons), so should be safe to merge.
Thanks to @soniakandah for the icons and @shakao for putting the buttons in the editor.