Refactor iframe communication and use MessageChannel #9945
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
This is all 100% backwards compatible with old embeds. To use the new MessageChannel stuff, you need to add
?frameid=<some-unique-id>
to the iframe's src url, then everything will just work and it will automatically switch to using the MessageChannel. If you don't add that, the new code falls back to using the good oldpostMessage
for communication. I went ahead and added it to the embed for the teacher tool and everything is working fine.We still have a few iframe embeds that I'll want to eventually switch over to this new stuff: