Teacher Tool: Max Count for Catalog Criteria #9986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… this is too specific.
…ks/teachertool/max_count_flag
thsparks
changed the title
eanders-ms
approved these changes
Apr 25, 2024
| return ( | ||
| <div className={css["catalog-item-label"]}> | ||
| <div className={css["action-indicators"]}> | ||
| {canAddMore ? ( | ||
| {isMaxed ? ( | ||
| <span className={css["max-label"]}>{Strings.Max}</span> |
There was a problem hiding this comment.
Not seeing a scss change. Did the max-label class already exist?
There was a problem hiding this comment.
Good catch. This just isn't needed or used. I'll remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to specify a maximum count for catalog criteria, which defines how many instances a user is allowed to have for a given catalog criteria. It also removes the attempted auto-detection of whether or not we should allow multiple instances (which was based the presence of parameters), since that didn't work well for criteria like "Must have [count] comments". If the field is not set, we assume no max.
I decided to go with a max count rather than a simple
allowMultipleboolean, because I thought it might be useful to have some criteria where multiple instances are allowed, but not an unlimited number of them. (For example, I've limited the copilot questions to a max of 10, since they're expensive.)I've also removed "All function definitions have comments" per feedback in microsoft/pxt-microbit#5597