Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility compliance: Improve share dialog accessibility #9989

Merged
merged 16 commits into from
May 9, 2024
Merged

Accessibility compliance: Improve share dialog accessibility #9989

merged 16 commits into from
May 9, 2024

Commits on Apr 17, 2024

  1. add alts, aria labels to images and input on share dialog

    @srietkerk
    srietkerk committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    1623f44 View commit details
    Browse the repository at this point in the history

  2. make editor toggle (the one used for embed) darker for color contrast

    @srietkerk
    srietkerk committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    3c4e4a2 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. added more aria labels

    @srietkerk
    srietkerk committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    1335c7d View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. changed selected logic for editor toggle

    @srietkerk
    srietkerk committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    d0deac2 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. share modal resizing on lower res screens is much better

    @srietkerk
    srietkerk committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    9247e3d View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. make share modal fit in the screen better on mobile

    @srietkerk
    srietkerk committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    37dc68f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/microsoft/pxt into srietk… 

    …erk/share-dialog-accessibility
    @srietkerk
    srietkerk committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    0bb899f View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. more fixes for share modal zooming

    @srietkerk
    srietkerk committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    b4f4a02 View commit details
    Browse the repository at this point in the history

  2. modifications to make user experience cleaner

    @srietkerk
    srietkerk committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    0dcb437 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/microsoft/pxt into srietk… 

    …erk/share-dialog-accessibility
    @srietkerk
    srietkerk committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    e0407a7 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. remove width logic for embed button, changing color instead

    @srietkerk
    srietkerk committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    22df435 View commit details
    Browse the repository at this point in the history

  2. Revert "remove width logic for embed button, changing color instead" 

    This reverts commit 22df435.
    @srietkerk
    srietkerk committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c584e8f View commit details
    Browse the repository at this point in the history

  3. adjusted programmatic rendering of embed button, took out extra scree… 

    …nsize breakpoint, modified embed css change
    @srietkerk
    srietkerk committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d8472f7 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. undo small mobile styling, add scrolling to smare modal, fix focusabl… 

    …e in focustrap, unite it with focusable for focuslist
    @srietkerk
    srietkerk committed May 8, 2024
    Configuration menu
    Copy the full SHA
    9ae3b08 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/microsoft/pxt into srietk… 

    …erk/share-dialog-accessibility
    @srietkerk
    srietkerk committed May 8, 2024
    Configuration menu
    Copy the full SHA
    267701a View commit details
    Browse the repository at this point in the history

  3. added predicate to findnextfocusable, made alt and aria label more ge… 

    …neric for simulator thumbnail, got rid of important on embed button styling
    @srietkerk
    srietkerk committed May 8, 2024
    Configuration menu
    Copy the full SHA
    07001ff View commit details
    Browse the repository at this point in the history