-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library code should be a virtual document #5259
Comments
@karthiknadig do you know if it makes sense to transfer this to Pylance, or would it need to be done in vscode-python? |
hey @isidorn! During housekeeping I transferred this to the Pylance repo and then talked about this with the team. We were thinking whether it wouldn't make more sense for Pylance to return the content with a flag saying it should be read only or not (and then VS Code would handle that appropriately)? For context, it's not uncommon for users to want to edit their stub files ( |
@luabud thanks for discussing with the team. You understand the needs of the python users much better than me, and if you decided that editing stub files makes sense then we should allow that. As for Code pointer https://github.com/microsoft/vscode/blob/isidorn/account-avatar/src/vscode-dts/vscode.d.ts#L1802 Though if this is deemed as not low-hanging fruit feel free to close it as out of scope. |
We're not a I think in order for this to work we'd have to create a custom URI scheme for built in files. Then we'd be a content provider for just that scheme. |
thanks all for the additional context! I'll close this as out of scope then 😊 |
Hi VS Code dev here 👋
Have the following code
Go to references on
float
-> notice a new editor appears with editable content.This feels like a very bad experience since this is library code and should be read only.
As @jrieken suggest Python should be a virtual document provider, as a virtual document fits this use case much better.
fyi @luabud
The text was updated successfully, but these errors were encountered: